Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix spec validation #255

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Nov 29, 2024

Summary

Notes

  • Supersedes Fix CI and spec versions #182.
  • Someone please mark the issues as closeable by this PR (seems like I don't have the rights to do so).
  • It would probably make sense to target this PR into master, but since Add format script and run it #241 is targeting v0.8.0, I did the same.
  • The title says the fix is partial because I do not guarantee the underlying validation is complete.

@FabijanC FabijanC changed the title Fix validate.js Fix spec validation Nov 29, 2024
@FabijanC FabijanC changed the title Fix spec validation Partially fix spec validation Nov 29, 2024
Copy link
Collaborator

@amanusk amanusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants