feat(common): implementing cargo-chef in dockerfile for better dependencies layer caching #2228
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2228 +/- ##
==========================================
- Coverage 66.24% 66.23% -0.02%
==========================================
Files 139 139
Lines 18343 18343
Branches 18343 18343
==========================================
- Hits 12151 12149 -2
Misses 4895 4895
- Partials 1297 1299 +2 ☔ View full report in Codecov by Sentry. |
idan-starkware
force-pushed
the
idan/docker-papyrus-dependencies-cache
branch
2 times, most recently
from
672fc4b to
34fe4ce
Compare
idan-starkware
changed the title
idan-starkware
changed the title
idan-starkware
changed the title
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @eranreshef-starkware)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @idan-starkware)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @idan-starkware)
Dockerfile line 48 at r5 (raw file):
ENV CARGO_INCREMENTAL=0 # Add the target for x86_64-unknown-linux-musl and compile papyrus_node.
the documentation here needs to change
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @eranreshef-starkware)
Dockerfile line 48 at r5 (raw file):
Previously, eranreshef-starkware (Eran Reshef) wrote…
the documentation here needs to change
Done.
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status:
…kerfile with recent changes
…kerfile with recent changes
idan-starkware
force-pushed
the
idan/docker-papyrus-dependencies-cache
branch
from
0986877 to
1ca81a5
Compare
This change is