feat: support keplr wallet #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, changes look good. Can you fix the formatting issue and then I'll merge it. |
|
@avimak Do we need the implementation to be deployed to production to merge this PR? We are still working on it. |
Yes, otherwise dapps will display it to users, and if they choose keplr, they'll be unable to use it, leading to potential user churn, which ultimately harms the dapps. |
|
Hey @delivan , the change looks good now that the wallet is available. Please fix the tests/ci and we're good to merge. |
|
I missed this. Can you check again? @fracek |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.