Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use => useResource #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use => useResource #25

wants to merge 1 commit into from

Conversation

littledan
Copy link

No description provided.

Copy link

stackblitz bot commented Apr 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ❌ Failed (Inspect) Apr 1, 2024 7:04pm

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Looks like this repo has some needed maintenance done.
Vercel says useResource doesn't exist, yet, here it is:
https://github.com/starbeamjs/starbeam/blob/main/packages/react/react/tests/resource-stages.spec.ts#L4

@NullVoxPopuli
Copy link
Contributor

@littledan I've gotten deploy working again, but Vercel is somehow blocking merge 😅
image

any chance you can rebase? <3

@NullVoxPopuli
Copy link
Contributor

ok, so I found the issue -- because we're pre 1.0, we've only been publishing under the unstable tag on NPM for the last year, and @starbeam/react doesn't have useResource until a more current version of @starbeam/react (such as under the unstable tag)`.

But to upgrade everything to the unstable tag, we have to upgrade other things -- and @starbeam/js doesn't exist with the unstable tag (same with @starbeam/timeline). Upgrading all packages except these two causes some type errors (as one would expect), so it seems these docs have fallen out of sync, and need an overhaul.

In the mean time tho, there is this other repo here:

Which is more a spike than anything, but is more up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants