Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude testdata from published crate #390

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

weiznich
Copy link
Contributor

This commit removes the test data from the published crate.

Fixes #389

This commit removes the test data from the published crate.

Fixes stanislav-tkach#389
@stanislav-tkach
Copy link
Owner

Thank you for the pull request! Please ignore the failed MLC job. Personally I would probably use exclude instead of include, but I guess it is OK. Still if you can share you thoughts regarding using include over exclude feel free to share.

@weiznich
Copy link
Contributor Author

I've gone with include as that also prevents accidentally adding files that exist in the local checkout while publishing.

@stanislav-tkach
Copy link
Owner

Makes sense, thank you!

@stanislav-tkach stanislav-tkach merged commit d824f1f into stanislav-tkach:master Dec 11, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Released versions contain test data
2 participants