Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failling test for node paths with parens #61

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattwynne
Copy link
Contributor

@mattwynne mattwynne commented Jul 19, 2021

Description

See #62

This PR is just a failing test to reproduce the problem. I'm hoping it should help someone who's a newcomer to open source and wants to contribute a fix.

I expect we can close this PR without merging it when someone submits a better PR that includes a fix 😄

Motivation and Context

Failing test to reproduce #62

How Has This Been Tested?

Added a new test case in spec/error-stack-parser-spec.js for this scenario.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • node_modules/.bin/jscs -c .jscsrc error-stack-parser.js passes without errors
  • npm test passes without errors
  • I have read the contribution guidelines
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

@mattwynne mattwynne force-pushed the allow-parens-in-node-filename branch from 3bbcef2 to 8f96eab Compare July 19, 2021 21:16
@mattwynne
Copy link
Contributor Author

I don't know who needs to hear this but I have no node_modules/.bin/jscs in my local project. Is this step in the template out of date?

@niftylettuce
Copy link
Contributor

If this is still an issue, can you resolve the conflict and ping me back once done?

@mattwynne
Copy link
Contributor Author

We ended up solving the problem by switching to stackchain so I've lost personal interest in this I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants