chore: use eslint

stacksjs · Oct 19, 2024 · 2f01319 · 2f01319
1 parent a590fe7
commit 2f01319
Show file tree

Hide file tree

Showing 8 changed files with 289 additions and 24 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,25 +1,153 @@
 {
-  "typescript.tsdk": "node_modules/typescript/lib",
+  // Disable the default formatter, use eslint instead
   "prettier.enable": false,
-  "editor.defaultFormatter": "biomejs.biome",
-  "editor.formatOnSave": true,
+  "biome.enabled": false,
+  "editor.formatOnSave": false,
+  // Auto fix
   "editor.codeActionsOnSave": {
-    "quickfix.biome": "explicit",
-    "source.organizeImports.biome": "explicit"
+    "source.fixAll.eslint": "explicit",
+    "source.organizeImports": "never"
   },
-  "[jsonc]": {
-    "editor.defaultFormatter": "biomejs.biome"
+  // Silent the stylistic rules in you IDE, but still auto fix them
+  "eslint.rules.customizations": [
+    {
+      "rule": "style/*",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "format/*",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "*-indent",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "*-spacing",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "*-spaces",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "*-order",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "*-dangle",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "*-newline",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "*quotes",
+      "severity": "off",
+      "fixable": true
+    },
+    {
+      "rule": "*semi",
+      "severity": "off",
+      "fixable": true
+    }
+  ],
+  // Enable eslint for all supported languages
+  "eslint.validate": [
+    "javascript",
+    "javascriptreact",
+    "typescript",
+    "typescriptreact",
+    "vue",
+    "html",
+    "markdown",
+    "json",
+    "jsonc",
+    "yaml",
+    "toml",
+    "xml",
+    "gql",
+    "graphql",
+    "astro",
+    "svelte",
+    "css",
+    "less",
+    "scss",
+    "pcss",
+    "postcss"
+  ],
+  "[stx]": {
+    "editor.defaultFormatter": "dbaeumer.vscode-eslint"
   },
+  // Shell
+  "[shellscript]": {
+    "editor.defaultFormatter": "foxundermoon.shell-format"
+  },
+  // Markdown
+  "[markdown]": {
+    "editor.defaultFormatter": "DavidAnson.vscode-markdownlint",
+    "editor.formatOnSave": true
+  },
+  "[dockerfile]": {
+    "editor.defaultFormatter": "foxundermoon.shell-format"
+  },
+  "markdownlint.config": {
+    "default": true,
+    "MD033": {
+      "allowed_elements": [
+        "details",
+        "summary",
+        "VPTeamPage",
+        "VPTeamPageTitle",
+        "VPTeamMembers",
+        "script"
+      ]
+    },
+    "MD041": false
+  },
+  "typescript.preferGoToSourceDefinition": true,
+  "editor.quickSuggestions": {
+    "strings": true
+  },
+  "git.enableSmartCommit": true,
+  "npm.enableRunFromFolder": true,
+  "npm.packageManager": "bun",
+  "editor.gotoLocation.multipleDefinitions": "goto",
+  "search.exclude": {
+    "**/node_modules": true,
+    "**/cdk.out": true,
+    "**/dist": true,
+    "CHANGELOG.md": true
+  },
+
   "cSpell.ignorePaths": ["node_modules"],
   "cSpell.dictionaries": ["custom-dictionary"],
   "cSpell.diagnosticLevel": "Hint",
   "cSpell.customDictionaries": {
-    "bun-plugin-yml": {
+    "bun-plugin-dtsx": {
       "name": "custom-dictionary",
       "path": "./.vscode/dictionary.txt",
       "scope": "user",
       "addWords": true
     },
-    "custom": true
-  }
+    "custom": true // enable the `custom` dictionary
+  },
+  "terminal.integrated.scrollback": 10000,
+  "grammarly.files.include": [
+    "**/README.md",
+    "**/readme.md",
+    "**/*.txt"
+  ],
+  "grammarly.files.exclude": [
+    "**/dictionary.txt"
+  ]
 }
diff --git a/.zed/settings.json b/.zed/settings.json
@@ -1,13 +1,139 @@
 // For a full list of overridable settings, and general information on folder-specific settings,
 // see the documentation: https://zed.dev/docs/configuring-zed#settings-files
 {
-  "formatter": {
-    "language_server": {
-      "name": "biome"
+  "languages": {
+    "JavaScript": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "TypeScript": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "HTML": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "CSS": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "Markdown": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "JSON": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "JSONC": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "YAML": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "XML": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
+    },
+    "TOML": {
+      "formatter": {
+        "code_actions": {
+          "source.fixAll.eslint": true
+        }
+      }
     }
   },
-  "code_actions_on_format": {
-    "source.fixAll.biome": true,
-    "source.organizeImports.biome": true
+  "lsp": {
+    "eslint": {
+      "settings": {
+        "rulesCustomizations": [
+          {
+            "rule": "style/*",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "format/*",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "*-indent",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "*-spacing",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "*-spaces",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "*-order",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "*-dangle",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "*-newline",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "*quotes",
+            "severity": "off",
+            "fixable": true
+          },
+          {
+            "rule": "*semi",
+            "severity": "off",
+            "fixable": true
+          }
+        ]
+      }
+    }
+  },
+  "file_types": {
+    "JavaScript": [
+      "buddy"
+    ]
   }
 }
diff --git a/biome.json b/biome.json
diff --git a/bun.lockb b/bun.lockb
diff --git a/commitlint.config.js b/commitlint.config.js
@@ -7,7 +7,7 @@ export default {
   },
   prompt: {
     messages: {
-      type: "Select the type of change that you're committing:",
+      type: 'Select the type of change that you\'re committing:',
       scope: 'Select the SCOPE of this change (optional):',
       customScope: 'Select the SCOPE of this change:',
       subject: 'Write a SHORT, IMPERATIVE tense description of the change:\n',
@@ -40,7 +40,7 @@ export default {
         emoji: ':package:',
       },
       { value: 'ci', name: 'ci:       🎡  Changes to our CI configuration files and scripts', emoji: ':ferris_wheel:' },
-      { value: 'chore', name: "chore:    🔨  Other changes that don't modify src or test files", emoji: ':hammer:' },
+      { value: 'chore', name: 'chore:    🔨  Other changes that don\'t modify src or test files', emoji: ':hammer:' },
       { value: 'revert', name: 'revert:   ⏪️  Reverts a previous commit', emoji: ':rewind:' },
     ],
     useEmoji: false,

diff --git a/eslint.config.js b/eslint.config.js
@@ -0,0 +1,15 @@
+import stacks from '@stacksjs/eslint-config'
+
+export default stacks({
+  stylistic: {
+    indent: 2,
+    quotes: 'single',
+  },
+
+  typescript: true,
+  jsonc: true,
+  yaml: true,
+  ignores: [
+    'fixtures/**',
+  ],
+})
diff --git a/test/dts-auto.test.ts b/test/dts-auto.test.ts
@@ -1,7 +1,7 @@
+import type { OnLoadResult, PluginBuilder } from 'bun'
 import { afterAll, beforeAll, describe, expect, it } from 'bun:test'
 import fs from 'node:fs'
 import path from 'node:path'
-import type { OnLoadResult, PluginBuilder } from 'bun'
 import { dts, generate } from '../src/index'
 
 const tempDir = path.resolve(process.cwd(), 'test-temp')

diff --git a/tsconfig.json b/tsconfig.json
@@ -12,12 +12,12 @@
     "strict": true,
     "strictNullChecks": true,
     "declaration": true,
-    "isolatedDeclarations": true,
     "declarationMap": true,
     "noEmit": true,
     "outDir": "./dist",
     "esModuleInterop": true,
     "forceConsistentCasingInFileNames": true,
+    "isolatedDeclarations": true,
     "skipDefaultLibCheck": true,
     "skipLibCheck": true
   }