-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Apply Clippy lint collection_is_never_used
#5654
base: develop
Are you sure you want to change the base?
chore: Apply Clippy lint collection_is_never_used
#5654
Conversation
…nd fix conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good to me. I just had some minor comments. It seems like the majority of these are from copy/pastes from one test to another.
…nd fix conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Make sure integration tests pass on retry. |
Description
Apply Clippy lint
collection_is_never_used
. This found a lot of collections, mostly in test code, that were created but never read. These fell into a few different categories:#[allow(clippy::collection_is_never_read)]
Note that
collection_is_never_used
is a "Nursery" lint, meaning it's not considered stable/accurate. It's not in the default set of lints Clippy runs, but still useful for finding unused code