Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Nakamoto block support for stacks-insepct try-mine #5584

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: Nakamoto block support for stacks-insepct try-mine #5584

wants to merge 2 commits into from
+91 −85

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Dec 17, 2024 •
edited
Loading

Description

Add Nakamoto block support to stacks-inspect try-mine

Applicable issues

Additional info (benefits, drawbacks, caveats)

This works with the testnet chainstate I've been using for testing, but I'm not sure if there are any edge cases I need to specifically handle here, depending on where in the tenure the block is

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@jbencin jbencin requested a review from a team as a code owner December 17, 2024 20:29
@jbencin jbencin mentioned this pull request Dec 17, 2024
Open
@jcnelson jcnelson requested review from obycode and jcnelson December 18, 2024 16:06
obycode
obycode reviewed Dec 18, 2024
View reviewed changes
stackslib/src/cli.rs Outdated Show resolved Hide resolved
@jbencin jbencin force-pushed the feat/try-mine-nakamoto branch from 37cc6d9 to 06cbf1c Compare December 20, 2024 17:12
@jbencin jbencin force-pushed the feat/try-mine-nakamoto branch from 06cbf1c to 86032d5 Compare December 20, 2024 17:18
@jbencin jbencin mentioned this pull request Dec 20, 2024
Open
5 tasks
obycode
obycode approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obycode obycode obycode approved these changes

@jcnelson jcnelson Awaiting requested review from jcnelson

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbencin @obycode