feat: add validation for complete-deposit transactions #545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #479.
Changes
AsContractCall::validate
function to have a different signature.CompleteDepositV1::validate
function.CompleteDepositV1
struct. These new parameters should be used in the contract call once feat: check against known burn hash when completing deposit #493 gets updated and lands.Note that when #543 gets done we'll probably want to add another integration test, but the logic introduced here should be correct and won't need much updating (famous last words).
Testing Information
This PR adds integration tests that checks for each of the failure modes in the function.
Checklist: