-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: signer /info
api endpoint
#1251
feat: signer /info
api endpoint
#1251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look, will have to circle back.
…-endpoint-to-the-signer-app
Note: I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left one style nit.
…-endpoint-to-the-signer-app
Description
Closes: #1017
Changes
/info
endpoint to the signer's API (I'm thinking we reserve/health
for connectivity checks and reporting connection errors, etc.).getnetworkinfo
andgetblockchaininfo
RPC methods toBitcoinInteract
.Example response from
devenv
:Values which are not available (i.e. either missing or an error occurred) are returned as
null
, my thinking is that this should report as much information as possible and be infallible, and we use a/health
endpoint for having simple db/bitcoin/stacks connectivity checks and report errors.Testing Information
Added additional unit tests and tested pretty extensively against
devenv
.Checklist: