Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1200 feature signers allow second dkg after specific block height #1205

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cylewitruk
Copy link
Member

Description

Closes: #1200

Changes

Changes the check in the handle_wsts_message method for DkgBegin messages in the transaction signer to conditionally allow a second DKG run if:

  • There has not been a DKG run yet (i.e. no entries in the signer's dkg_shares db table), OR
  • If DKG has been run exactly once (one entry in the signer's dkg_shares db table) AND a DKG re-run height is configured AND the current bitcoin chain tip height is >= the configured re-run height

This copies a snippet of the config code in #1201 to be able to retrieve the config value for the DKG re-run height.

Testing Information

This currently lacks additional tests because my integration env is borked for some reason; looking into that now.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cylewitruk cylewitruk added sbtc signer binary The sBTC Bootstrap Signer. key rotation The functionality to rotate a private key for a signer in sBTC-v1. labels Jan 10, 2025
@cylewitruk cylewitruk added this to the sBTC: Key rotation milestone Jan 10, 2025
@cylewitruk cylewitruk self-assigned this Jan 10, 2025
@cylewitruk cylewitruk linked an issue Jan 10, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
key rotation The functionality to rotate a private key for a signer in sBTC-v1. sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

[Feature]: Signers allow second DKG after specific block height
1 participant