Add discard functionality for conditional tests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an example of a Clarity preliminary function designed to pair with a conditional property test. It also includes a comment outlining the rules for structuring preliminary functions, covering their requirements.
This commit updates the conditional property test function by replacing its early return condition with a call to the corresponding preliminary function. This change clarifies the role of preliminary functions in validating input before executing the main test logic.
moodmosaic
reviewed
Nov 1, 2024
This commit adds checks for preliminary functions to ensure they follow the rules. It checks that the parameters match those of the test functions and that the return type is a boolean.
This commit adds the preliminary function run before the test function and stores the result.
BowTiedRadone
commented
Nov 1, 2024
|
Made some optional/stylish tweaks here. Can be tested with:
Here is an alternative one:
|
|
Perhaps dim the generated args for discarded tests and that’s it. No need to even print (discarded) at all. |
This commit adds conditional logic to property testing based on preliminary functions' response. Property tests with a preliminary function won’t need an initial condition. The updated `test-slice-list-int` demonstrates this new setup. This commit also includes a minor indentation fix.
Co-authored-by: Nikos Baxevanis <[email protected]>
This commit updates the `ansicolors` used for property testing logging. Thanks to @moodmosaic for this great proposal: 3adcfe4.
BowTiedRadone
changed the title
moodmosaic
reviewed
Nov 4, 2024
Co-authored-by: Nikos Baxevanis <[email protected]>
moodmosaic
reviewed
Nov 6, 2024
Co-authored-by: Nikos Baxevanis <[email protected]>
Co-authored-by: Nikos Baxevanis <[email protected]>
Co-authored-by: Nikos Baxevanis <[email protected]>
Thanks to @moodmosaic for the great suggestion in https://github.com/stacks-network/rendezvous/pull/40/files#r1830543508.
BowTiedRadone
force-pushed
the
feat/discard-tests
branch
from
f9a6c51 to
3d12d0b
Compare
moodmosaic
reviewed
Nov 7, 2024
moodmosaic
reviewed
Nov 7, 2024
This commit adds tests for `isParamsMatch` and `isReturnTypeBoolean`.
BowTiedRadone
force-pushed
the
feat/discard-tests
branch
from
b45f1b4 to
7eabfaf
Compare
If there are discarded tests, output is green and yellow but the result still shows as green. Better to leave it uncolored.
moodmosaic
approved these changes
Nov 8, 2024
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to
discardproperty tests that don't meet certain preconditions. It partially addresses #38.Sample output
When a test is discarded, it is now highlighted with a
[WARN]and dimmed function arguments: