Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf reflection for loading runtime configuration #2025

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Use protobuf reflection for loading runtime configuration #2025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7e25ebb
Use protobuf reflection for loading runtime configuration
Molter73 Feb 3, 2025
e010698
Handle cases where the file doesn't exist
Molter73 Feb 4, 2025
46cca31
Minor cleanup + ignore asan false positive
Molter73 Feb 4, 2025
56b45ff
Add runtime configuration log statement + log events correctly on int…
Molter73 Feb 4, 2025
4fa1456
Provide defaults that are different from protobuf defaults
Molter73 Feb 4, 2025
8ad639f
Add case insensitive enum lookup
Molter73 Feb 4, 2025
bb08c35
Add some doxygen to the new classes
Molter73 Feb 5, 2025
7d747d9
Replace stringstream with ParserError where it makes sense
Molter73 Feb 5, 2025
09100de
Some more small cleanups
Molter73 Feb 5, 2025
ff49a34
Simplify switch statement to if
Molter73 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion collector/collector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ int main(int argc, char** argv) {

CollectorConfig config;
config.InitCollectorConfig(args);
if (!ConfigLoader::LoadConfiguration(config)) {
if (ConfigLoader(config).LoadConfiguration() == collector::ConfigLoader::PARSE_ERROR) {
CLOG(FATAL) << "Unable to parse configuration file";
}

Expand Down
Loading
Loading