ROX-18384: remove slim images from upstream #1963
Conversation
| @@ -123,11 +109,9 @@ | |||
| msg: | |||
| - "Pushed the following images:" | |||
| - " {{ collector_image }}-{{ arch }}" | |||
| - " {{ collector_image }}-{{ arch }}-slim" | |||
| - " {{ collector_image }}-{{ arch }}-base" | |||
| - " {{ collector_image }}-{{ arch }}-latest" | |||
There was a problem hiding this comment.
Not a blocking comment and not aiming to be delay the PR by becoming a reviewer.
I recalled this our conversation https://redhat-internal.slack.com/archives/CFMQ5C2TT/p1733309587336659
Your changes in https://github.com/stackrox/stackrox/pull/13350/files#diff-9f1c5124b529a407693ba184291c9797252978fe4ce8770e1ddec20d811efd69L104 allow getting rid of publishing -latest.
Also, I believe -base wasn't used by StackRox. IIRC, it was created by the Collector build pipelines as something intermediate before drivers are injected and it becomes "the full collector".
| @@ -25,7 +25,7 @@ $ make image | |||
|
|
|||
There was a problem hiding this comment.
(not about this line)
I suppose what some of my comments allude to is the need for more testing in different version combinations.
Such as:
- New Central old
roxctl, canroxctlgenerate sensor manifests and can that be successfully deployed? In both versions of slim=true/false. - Old Central, new
roxctl, can sensor manifests be generated and successfully deployed? - Get old manifest-based secured cluster connected to new Central (probably start both old and then upgrade only Central). Does the UI display all things as expected? Can the secured cluster download probes through Central?
- Get old Helm-based and Operator-based secured clusters connected to new Central. UI fine? Functioning ok?
- Get old Central and connect new Helm-based and Operator-based secured clusters. All works well, including UI?
Description
Since we have deprecated full images from Collector, we now want to drop the -slim tag for all images, since all image flavours are now inherently slim.
This PR removes upstream slim image tagging from Collector.
There are sibling PRs, which I will list here as they become available, that remove slim image use in other areas (downstream builds and the main repo)
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be enough.