Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry first port open operation #1953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Retry first port open operation #1953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions integration-tests/suites/listening_ports.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,9 @@ func (s *ProcessListeningOnPortTestSuite) SetupSuite() {

s.serverURL = fmt.Sprintf("http://%s:%s", ip, port)

// Wait 5 seconds for the plop service to start
common.Sleep(5 * time.Second)

log.Info("Opening ports...")
s.openPort(8081)
// First query, we retry a few times until the flask app starts.
s.openPortWithRetry(8081, 30*time.Second)
s.openPort(9091)

common.Sleep(6 * time.Second)
Expand Down Expand Up @@ -144,10 +142,39 @@ func getProcessListeningOnPortsImage() string {
return config.Images().QaImageByKey("qa-plop")
}

func (s *ProcessListeningOnPortTestSuite) openPort(port uint16) {
func (s *ProcessListeningOnPortTestSuite) openPortRaw(port uint16) (bool, error) {
res, err := http.Get(fmt.Sprintf("%s/open/%d", s.serverURL, port))
if err != nil {
return false, err
}
return res.StatusCode == 200, nil
}

func (s *ProcessListeningOnPortTestSuite) openPort(port uint16) {
res, err := s.openPortRaw(port)
s.Require().NoError(err)
s.Require().True(res.StatusCode == 200)
s.Require().True(res)
}

func (s *ProcessListeningOnPortTestSuite) openPortWithRetry(port uint16, timeout time.Duration) {
tick := time.Tick(1 * time.Second)
timer := time.After(timeout)
for {
select {
case <-tick:
success, err := s.openPortRaw(port)
if err != nil {
log.Info("Failed to open port: %s", err)
continue
}
if success {
return
}
case <-timer:
s.FailNow("Failed to open port 8081")
}
}

}

func (s *ProcessListeningOnPortTestSuite) closePort(port uint16) {
Expand Down
Loading