-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.0.0 #14
Release v2.0.0 #14
Conversation
cf6e0d0
to
48d7ab9
Compare
That is not correct. Unknown pc: prefixed fields will be reported as invalid. @gadomski |
Alrighty, then should be v2.0.0. Thanks @m-mohr I'll update. |
48d7ab9
to
bce245d
Compare
Generally, the schema could be updated to a better version that we use in some other extensions. I'm not sure it's in the template extension yet, but if you go 2.0.0 preferrably also improve the schema ;-) |
Ok, I'll hold off on merging and see if I can get some time to update the schema 👍🏼 |
Here's a recent example of a "better" schema ;-) |
@m-mohr I did my best to ape the EO extension into the jsonschema, but full disclosure I don't play in jsonschema much so mistakes are quite possible. If you have time to take a look I'd appreciate 🙇🏼 . |
The CI tests fail, could you fix those first? :-) |
Yeah, I'm flailing around now — please ignore, I'll ping again when I get things green 🙇🏼 . |
4fb236e
to
db4d958
Compare
@m-mohr did my best to update the schema using the "better" version, so ready for re-review (finally). |
Oops! In the meantime I created an even better version 😅 (sorry!) It uses if/else instead of oneOf which makes the error reporting in JSON Schema less confusing to read and actually correctly validates fields "everywhere". Before it sometimes happened that parts were not validated. |
70f13f1
to
31b1dfa
Compare
@m-mohr ok I've updated with The New Way, and added some more tests (for assets and item assets, respectively). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the count in pc:statistics have a minimum value of 0 or 1?
Otherwise LGTM.
It could be a zero point file, that's allowed by most formats, so 0 seems right. |
@gadomski Yes, but there was NONE defined. I'm not talking about pc:count, but about pc:statistics.count! |
Whoops. I'll open an issue, thanks! |
The main changes are
pc:schemas
)pc:encoding
)Related issues