Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 #14

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Release v2.0.0 #14

merged 4 commits into from
Oct 24, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Mar 11, 2024

The main changes are

  • relaxing a required field to non-required (pc:schemas)
  • removing a field (pc:encoding)

Related issues

@m-mohr
Copy link
Contributor

m-mohr commented Mar 11, 2024

because [...] it is allowed to have fields w/ a pc: prefix that aren't in the extension.

That is not correct. Unknown pc: prefixed fields will be reported as invalid. @gadomski

@gadomski
Copy link
Member Author

Alrighty, then should be v2.0.0. Thanks @m-mohr I'll update.

@gadomski gadomski changed the title Release v1.1.0 Release v2.0.0 Mar 12, 2024
@m-mohr
Copy link
Contributor

m-mohr commented Apr 8, 2024

Generally, the schema could be updated to a better version that we use in some other extensions. I'm not sure it's in the template extension yet, but if you go 2.0.0 preferrably also improve the schema ;-)

@gadomski
Copy link
Member Author

gadomski commented Apr 8, 2024

Generally, the schema could be updated to a better version that we use in some other extensions. I'm not sure it's in the template extension yet, but if you go 2.0.0 preferrably also improve the schema ;-)

Ok, I'll hold off on merging and see if I can get some time to update the schema 👍🏼

@m-mohr
Copy link
Contributor

m-mohr commented Apr 8, 2024

Here's a recent example of a "better" schema ;-)
https://github.com/stac-extensions/eo/blob/9dfcf270dbd210e74ee1e06a15c50beedc2e3b5d/json-schema/schema.json

@gadomski
Copy link
Member Author

gadomski commented Apr 8, 2024

@m-mohr I did my best to ape the EO extension into the jsonschema, but full disclosure I don't play in jsonschema much so mistakes are quite possible. If you have time to take a look I'd appreciate 🙇🏼 .

@m-mohr
Copy link
Contributor

m-mohr commented Apr 8, 2024

The CI tests fail, could you fix those first? :-)
Or any specific issues I should look at?

@gadomski
Copy link
Member Author

gadomski commented Apr 8, 2024

The CI tests fail, could you fix those first? :-)

Yeah, I'm flailing around now — please ignore, I'll ping again when I get things green 🙇🏼 .

@gadomski
Copy link
Member Author

@m-mohr did my best to update the schema using the "better" version, so ready for re-review (finally).

@m-mohr
Copy link
Contributor

m-mohr commented Aug 21, 2024

Oops! In the meantime I created an even better version 😅 (sorry!)
https://github.com/stac-extensions/eo/blob/main/json-schema/schema.json
or
https://github.com/stac-extensions/raster/blob/main/json-schema/schema.json
I still need to generalize it for the template repository though.

It uses if/else instead of oneOf which makes the error reporting in JSON Schema less confusing to read and actually correctly validates fields "everywhere". Before it sometimes happened that parts were not validated.

@gadomski
Copy link
Member Author

@m-mohr ok I've updated with The New Way, and added some more tests (for assets and item assets, respectively).

Copy link
Contributor

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the count in pc:statistics have a minimum value of 0 or 1?

Otherwise LGTM.

@gadomski
Copy link
Member Author

Should the count in pc:statistics have a minimum value of 0 or 1?

It could be a zero point file, that's allowed by most formats, so 0 seems right.

@gadomski gadomski merged commit 4e065bf into main Oct 24, 2024
2 checks passed
@gadomski gadomski deleted the release/v1.1.0 branch October 24, 2024 20:29
@m-mohr
Copy link
Contributor

m-mohr commented Oct 24, 2024

@gadomski Yes, but there was NONE defined. I'm not talking about pc:count, but about pc:statistics.count!

@gadomski
Copy link
Member Author

Whoops. I'll open an issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

what is acutally needed for pc:schemas
3 participants