Use * instead of _ for italics #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues converting text with italics in the middle of the word, for example aaaaaa<i>italic</i>bbbb Or when the space at the end of the word is italicized: aaaaa<i>italic </i>bbbb Or when mixing bold / italic / bold+italic aaaa<i>italic<b>bolditalic</b>italic</i>bbb I have tested rendering the resulting markdown with both ReactMarkdown (https://github.com/remarkjs/react-markdown) and on iOS with the builtin AttributedString to confirm it renders correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues converting text with italics in the middle of the word, for example
aaaaaaitalicbbbb
Or when the space at the end of the word is italicized:
aaaaaitalic bbbb
Or when mixing bold / italic / bold+italic
aaaaitalicbolditalicitalicbbb
I have tested rendering the resulting markdown with both ReactMarkdown (https://github.com/remarkjs/react-markdown) and on iOS with the builtin AttributedString to confirm it renders correctly