Add [[noreturn]] attribute to Output::fatal, add SST_Exit() function #1175

leekillough · 2024-11-09T04:18:53Z

Fixes #1169 by adding [[noreturn]] to SST::Output::fatal().

Adds a SST::SST_Exit() function which ensures only a single thread exits if multiple threads call it simultaneously.

github-actions · 2024-11-09T04:19:25Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

github-actions · 2024-11-09T04:19:28Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2024-11-09T04:48:39Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2024-11-09T05:57:18Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

github-actions · 2024-11-09T05:57:32Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2024-11-09T06:07:50Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

github-actions · 2024-11-09T06:07:53Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2024-11-09T06:19:10Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

github-actions · 2024-11-09T06:19:12Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2024-11-09T06:28:06Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2024-11-09T06:28:15Z

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

feldergast

Thanks for putting this together. In general, things look good. Just need to address the clang-format errors and we can get it released for testing.

feldergast · 2024-11-11T17:05:19Z

src/sst/core/exit.cc

@@ -12,6 +12,7 @@
 #include "sst_config.h"

 #include "sst/core/exit.h"
+#include <exception>


Per the coding standards, includes of standard headers should go after all sst includes. This is probably contributing to the clang-format failure.

I ran clang-format but my version is newer than v12 and I didn't feel like trying to go back to an older version.

That's not promising for moving clang-format forward if it doesn't follow the header ordering settings in the .clang-format file. You can look at the diff of what it got with what it wanted in the "checks" tab in the PR. Just select the clang-format check and click in the Matrix box to bring up the results of the test.

It's too late to fix it now, but clang-format should have a version 1.2.3 directive for .clang-format files so that it behaves like a certain version. But as the number of versions increases, this becomes hard to test, and complicates the code to behave differently for different versions, although if this versioning scheme is done from the beginning, the versioned tests can be developed incrementally.

feldergast · 2024-11-11T17:16:27Z

src/sst/core/exit.h

@@ -117,6 +117,8 @@ class Exit : public Action
    bool single_rank;
 };

+[[noreturn]] void SST_Exit(int exit_code);


Not sure if exit.h is the best place for this function to live. One of the issues is that exit.h is being installed, though it really shouldn't be, and SST_Exit() shouldn't be part of the public API. The other issue is that even though the names match, the functionality isn't really related to the Exit object. Of the header files that aren't installed, I think simulation_impl.h is probably the best place for the SST_Exit() function (not as part of the Simulation_impl object, however). Since The function won't be part of the non-core API, I think it's fine to leave as is for now if you don't want to change it and we can reevaluate later.

Okay I can move it anywhere, to prevent it from being publicly exported / documented. The exit.h and exit.cc seemed logical, even if this function is unrelated to the Exit object.

Oh, and since Exit is a common name which might conflict with other uses, I used SST::SST_Exit instead of SST::Exit. If this deviates from normal SST naming conventions, such as case and underscores, it can be renamed. In Rev we use camelCase for variables / functions and CamelCase for types.

I think it makes sense to prefix it with SST. We haven't been good about enforcing naming conventions, though nominally we match the same camel case you describe. That being said, I think I like SST_Exit() better than SSTExit(). We can reevaluate later when we take a pass at cleaning up other names in the core.

github-actions · 2024-11-13T06:29:01Z

CLANG-FORMAT TEST - PASSED

github-actions · 2024-11-13T06:29:02Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2024-11-13T06:49:14Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

sst-autotester · 2024-11-13T17:49:22Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester · 2024-11-13T17:54:21Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1700
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1658
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1658
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 720
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 576
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 530
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 230
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 148
Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: leekillough

sst-autotester · 2024-11-13T18:01:39Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Result: FAILED
Build #: 1700
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements/1700/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Result: FAILED
Build #: 1658
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2/1658/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Result: FAILED
Build #: 1658
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2/1658/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Result: FAILED
Build #: 720
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore/720/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Result: FAILED
Build #: 576
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist/576/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Result: PASSED
Build #: 530
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core/530/consoleFull

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Result: FAILED
Build #: 230
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements/230/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Result: FAILED
Build #: 148
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore/148/consoleFull
Job: - Status: FAILURE

src/sst/core/simulation_impl.h

…o it in the header

github-actions · 2024-11-13T19:33:56Z

CMAKE-FORMAT TEST - PASSED

github-actions · 2024-11-13T19:33:57Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2024-11-13T19:49:14Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

sst-autotester · 2024-11-13T23:19:18Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester · 2024-11-13T23:24:02Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1701
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1659
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1659
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 721
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 577
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 531
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 231
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 149
Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: leekillough

sst-autotester · 2024-11-13T23:31:27Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Result: FAILED
Build #: 1701
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements/1701/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Result: FAILED
Build #: 1659
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2/1659/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Result: FAILED
Build #: 1659
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2/1659/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Result: FAILED
Build #: 721
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore/721/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Result: FAILED
Build #: 577
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist/577/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Result: PASSED
Build #: 531
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core/531/consoleFull

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Result: FAILED
Build #: 231
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements/231/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Result: FAILED
Build #: 149
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore/149/consoleFull
Job: - Status: FAILURE

leekillough · 2024-11-14T00:02:53Z

I'll investigate the failure. Maybe the simulation_impl.h file is not being included in the Output files.

I don't mind taking this slowly. I want to make sure it is safe.

feldergast · 2024-11-14T00:10:37Z

Just looked at the log. It appears that mpi.h is not included in simulation.cc.

leekillough · 2024-11-14T00:30:05Z

Just looked at the log. It appears that mpi.h is not included in simulation.cc.

Should we conditionally include mpi.h based on the MPI macro?

feldergast · 2024-11-14T01:21:13Z

Just looked at the log. It appears that mpi.h is not included in simulation.cc.

Should we conditionally include mpi.h based on the MPI macro?

Yes. We generally do this for including mpi.h:

#ifdef SST_CONFIG_HAVE_MPI
DISABLE_WARN_MISSING_OVERRIDE
#include <mpi.h>
REENABLE_WARNING
#endif

The extra macros are to suppress some of the known warnings in openmpi's version of mpi.h.

sst-autotester · 2024-11-14T04:46:55Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1702
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1660
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1660
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 722
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 578
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 532
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 232
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 150
Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: leekillough

sst-autotester · 2024-11-14T04:53:42Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Result: FAILED
Build #: 1702
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements/1702/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Result: FAILED
Build #: 1660
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2/1660/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Result: FAILED
Build #: 1660
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2/1660/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Result: FAILED
Build #: 722
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore/722/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Result: FAILED
Build #: 578
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist/578/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Result: PASSED
Build #: 532
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core/532/consoleFull

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Result: FAILED
Build #: 232
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements/232/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Result: FAILED
Build #: 150
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore/150/consoleFull
Job: - Status: FAILURE

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Nov 9, 2024

github-actions bot added AT: CMAKE-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 9, 2024

github-actions bot added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Nov 9, 2024

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Nov 9, 2024

leekillough force-pushed the SST_Exit branch from a443327 to 7103106 Compare November 9, 2024 06:07

github-actions bot added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Nov 9, 2024

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Nov 9, 2024

leekillough force-pushed the SST_Exit branch from 7103106 to 1159703 Compare November 9, 2024 06:18

github-actions bot added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Nov 9, 2024

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Nov 9, 2024

Add [[noreturn]] attribute to Output::fatal, add SST_Exit() function

923e5b9

leekillough force-pushed the SST_Exit branch from 1159703 to 923e5b9 Compare November 9, 2024 06:27

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 9, 2024

github-actions bot added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Nov 9, 2024

feldergast reviewed Nov 11, 2024

View reviewed changes

Move SST_Exit() to simulation_impl.h and simulation.cc

1839d2d

github-actions bot added AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Nov 13, 2024

feldergast added the AT: PRE-TEST INSPECTED label Nov 13, 2024

sst-autotester removed the AT: PRE-TEST INSPECTED label Nov 13, 2024

feldergast reviewed Nov 13, 2024

View reviewed changes

src/sst/core/simulation_impl.h Outdated Show resolved Hide resolved

Move SST_Exit() declaration to top of file since there a references t…

0068599

…o it in the header

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 13, 2024

feldergast self-assigned this Nov 13, 2024

feldergast added the AT: PRE-TEST INSPECTED label Nov 13, 2024

sst-autotester removed the AT: PRE-TEST INSPECTED label Nov 13, 2024

Add [[noreturn]] attribute to Output::fatal, add SST_Exit() function #1175

Are you sure you want to change the base?

Add [[noreturn]] attribute to Output::fatal, add SST_Exit() function #1175

Conversation

leekillough commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

sst-autotester commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

github-actions bot commented Nov 9, 2024

feldergast left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

sst-autotester commented Nov 13, 2024

sst-autotester commented Nov 13, 2024

sst-autotester commented Nov 13, 2024

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Using Repos:

sst-autotester commented Nov 13, 2024

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Job: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Job: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

sst-autotester commented Nov 13, 2024

sst-autotester commented Nov 13, 2024

sst-autotester commented Nov 13, 2024

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Using Repos:

sst-autotester commented Nov 13, 2024