Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leak-prone CustomData in stdMem interface. #1001

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Fix leak-prone CustomData in stdMem interface. #1001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/sst/core/interfaces/stdMem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,9 +913,9 @@ class StandardMem : public SubComponent
return str.str();
}

CustomData* data; /* Custom class that holds data for this event */
Addr iPtr; /* Instruction pointer */
uint32_t tid; /* Thread ID */
std::unique_ptr<CustomData> data; /* Custom class that holds data for this event */
Addr iPtr; /* Instruction pointer */
uint32_t tid; /* Thread ID */
};

class CustomResp : public Request
Expand Down Expand Up @@ -951,9 +951,9 @@ class StandardMem : public SubComponent
return str.str();
}

CustomData* data; /* Custom class that holds data for this event */
Addr iPtr; /* Instruction pointer */
uint32_t tid; /* Thread ID */
std::unique_ptr<CustomData> data; /* Custom class that holds data for this event */
Addr iPtr; /* Instruction pointer */
uint32_t tid; /* Thread ID */
};

/* Class for implementation-specific converter functions */
Expand Down
Loading