Fix formatting issue so you don't need to gsub

[locochris]

eg. current behaviour

GlobalPhone.parse("1520123456", "IE").national_format
#=> "1520  123 456"

gsub workaround:

GlobalPhone.parse("1520123456", "IE").national_format.gsub(/\s+/, ' ')
#=> "1520 123 456"

[benkitzelman]

+1 this :)

[rubemz]

👍

[xescugc]

👍

[wallymathieu]

Thanks!

[toxaq]

Awesome, thanks.

[nicolasblanco]

Really need this to be merged 👍 !

[eileencodes]

Hi @locochris, thanks for the PR! 😄 Can you tell me what bug not discarding the whitespace is causing?

[toxaq]

@eileencodes there's an example in the test included in the PR or did you mean something else?

[locochris]

@eileencodes as @toxaq mentioned - its a formatting issue and there's a failing test case in the PR.
It saves us (and probably @nicolasblanco , @toxaq et al) from having to write .gsub(/\s+/, ' ') type code for no good reason whenever we want to display the national number.

[eileencodes]

The test really isn't an example of how having whitespace would break since it existed prior to this PR. Can you update the commit message to explain that it fixes a formatting issue so you don't need to gsub? I read it as whitespace was causing broken behavior.

[locochris]

no worries - how's it look now @eileencodes ?
BTW its whitespace in the output not in the input (if there was any confusion there).
ie. it was a poorly formatted assertion in the test.

[sesam]

is sstephenson the most active fork? I'd use this gem if I can rely on getting clean output.