Skip to content
This repository was archived by the owner on Jun 10, 2018. It is now read-only.

Adds logger / Removes raise exception when unknown territory #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/global_phone/logger.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
require 'logger'

module GlobalPhone
class << self
attr_writer :logger

def logger
@logger ||= Logger.new($stdout).tap do |log|
log.progname = self.name
end
end
end
end
4 changes: 3 additions & 1 deletion lib/global_phone/parsing.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
require 'global_phone/number'
require 'global_phone/utils'
require 'global_phone/logger'

module GlobalPhone
module Parsing
def parse(string, territory_name)
string = Number.normalize(string)
territory = self.territory(territory_name)
raise ArgumentError, "unknown territory `#{territory_name}'" unless territory

GlobalPhone.logger.warn "unknown territory `#{territory_name}'" unless territory

if starts_with_plus?(string)
parse_international_string(string)
Expand Down
23 changes: 23 additions & 0 deletions test/parsing_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
require File.expand_path('../test_helper', __FILE__)
require 'pry'
require 'stringio'

module GlobalPhone
class ParsingTest < TestCase
test "valid territory" do
number = context.parse("+351 91 335 00 00", "PT")
assert_not_nil number
assert_kind_of Territory, number.territory
end

test "unknown territory" do
stdout = StringIO.new
$stdout = stdout
number = context.parse("+93 1289312", "PN")
$stdout = STDOUT

assert_nil number
assert_match 'unknown territory', stdout.string
end
end
end