fix: handle missing share files in Session.getShare and ShareNext.get #5512
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storage.read throws NotFoundError on ENOENT, causing unhandled promise rejections when checking share status for unshared sessions. The TUI calls these functions during sync, resulting in ~1 error/second. Add .catch(() => undefined) to gracefully handle missing share files, consistent with similar patterns elsewhere in the codebase (e.g. project.ts:95, summary.ts:181). Co-Authored-By: Hector <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Storage.readthrowingNotFoundErrorwhen checking share status for unshared sessionsChanges
.catch(() => undefined)toSession.getShare()andShareNext.get()to gracefully handle missing share filesproject.ts:95,summary.ts:181)