Skip to content

fix(enterprise): remove deferStream to fix share page hydration mismatch #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
code-yeongyu wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −12
Open

fix(enterprise): remove deferStream to fix share page hydration mismatch #5511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions packages/enterprise/src/routes/share/[shareID].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,18 +138,13 @@ const getData = query(async (shareID) => {

export default function () {
const params = useParams()
const data = createAsync(
async () => {
if (!params.shareID) throw new Error("Missing shareID")
const now = Date.now()
const data = getData(params.shareID)
console.log("getData", Date.now() - now)
return data
},
{
deferStream: true,
},
)
const data = createAsync(async () => {
if (!params.shareID) throw new Error("Missing shareID")
const now = Date.now()
const data = getData(params.shareID)
console.log("getData", Date.now() - now)
return data
})

createEffect(() => {
console.log(data())
Expand Down