Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't poll S3 unless we have reason to think there are new files available #553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Jan 18, 2025

Keep the minio polling interval but do nothing if the current transform status does not indicate more files than the last time we looked in S3.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (847d28a) to head (5ac484b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          29       29           
  Lines        1823     1824    +1     
=======================================
+ Hits         1688     1689    +1     
  Misses        135      135           
Flag Coverage Δ
unittests 92.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant