Fix shell scripts not being added to PATH in software bundle #680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #678
As discussed in the related issue, changes in #654 deprecated old and unsupported use of copying/distributing
.sh
scripts as part of thepolar2grid
python package installation. When I made that change I didn't realize that I was depending on it as part of thebin/env.sh
script.To any users reading this, we still recommend never sourcing the environment scripts (ex.
source $POLAR2GRID_HOME/bin/polar2grid_env.sh
, but some users still do. Instead we recommend calling the high-level scripts with an absolute path (ex.POLAR2GRID_HOME/bin/polar2grid.sh
).This PR fixes this problem by softlinking the high-level
.sh
scripts into the low-level python runtimelibexec/python_runtime/bin/
directory. This avoids other things inbin/
being added to your PATH.In the long run, although not implemented here, the environment scripts should maybe be moved somewhere else (maybe the root directory) and not included in
bin/
as they are not scripts to be executed. That's a little too much backwards incompatible for one release so I'm not going to do it here.