Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell scripts not being added to PATH in software bundle #680

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 2, 2024

Closes #678

As discussed in the related issue, changes in #654 deprecated old and unsupported use of copying/distributing .sh scripts as part of the polar2grid python package installation. When I made that change I didn't realize that I was depending on it as part of the bin/env.sh script.

To any users reading this, we still recommend never sourcing the environment scripts (ex. source $POLAR2GRID_HOME/bin/polar2grid_env.sh, but some users still do. Instead we recommend calling the high-level scripts with an absolute path (ex. POLAR2GRID_HOME/bin/polar2grid.sh).

This PR fixes this problem by softlinking the high-level .sh scripts into the low-level python runtime libexec/python_runtime/bin/ directory. This avoids other things in bin/ being added to your PATH.

In the long run, although not implemented here, the environment scripts should maybe be moved somewhere else (maybe the root directory) and not included in bin/ as they are not scripts to be executed. That's a little too much backwards incompatible for one release so I'm not going to do it here.

@djhoese djhoese added bug component:build related to building or release creation labels Feb 2, 2024
@djhoese djhoese self-assigned this Feb 2, 2024
@djhoese djhoese merged commit 1232a8c into ssec:main Feb 2, 2024
8 checks passed
@djhoese djhoese deleted the bugfix-sh-swbundle-path branch February 2, 2024 16:28
@coveralls
Copy link

Coverage Status

coverage: 85.333%. remained the same
when pulling be3e2e6 on djhoese:bugfix-sh-swbundle-path
into 86b4f28 on ssec:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component:build related to building or release creation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcing P2G env variable script no longer adds access to polar2grid.sh in $PATH
2 participants