Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial FCI Level 1c NetCDF reader #653

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 21, 2023

No description provided.

@djhoese djhoese added enhancement component:reader reading/loading data labels Nov 21, 2023
@djhoese djhoese added this to the Geo2Grid 1.2 milestone Nov 21, 2023
@djhoese djhoese self-assigned this Nov 21, 2023
@djhoese
Copy link
Member Author

djhoese commented Nov 21, 2023

There are a lot of optimizations and fixes being done on the Satpy and other pytroll package sides for this. So while this reader wrapper can be merged if/when tests pass the actual Geo2Grid release that includes it should not be done (or at least advertised) until these upstream changes have been merged and released.

These changes include:

  1. Caching and other optimizations to loading/reading the files from disk.
  2. Various fixes to preserve 32-bit floats and avoid upcasting to 64-bit floats which is a waste of memory.
  3. Fixes for issues with some RGB composites in recent versions of Satpy.

@coveralls
Copy link

Coverage Status

coverage: 85.317% (+0.03%) from 85.288%
when pulling d8468da on djhoese:feature-fci-reader
into 30a8d70 on ssec:main.

@djhoese djhoese merged commit 73fa52e into ssec:main Nov 21, 2023
9 checks passed
@djhoese djhoese deleted the feature-fci-reader branch November 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants