Use https for git submodule for CodeSpaces to work #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the git submodule URL from SSH to HTTPS format to enable compatibility with GitHub Codespaces, where SSH authentication can be problematic.
- Changed the distro submodule URL from SSH (
git@github.com:python-distro/distro.git) to HTTPS (https://github.com/python-distro/distro.git)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the protocol from SSH to HTTPS for the distro submodule. When starting a GitHub Codespaces set up with a dotfiles repo using dotbot with this plugin, it fails due to SSH auth issues etc.
Since the distro module is unrelated to this dotbot plugin, as in they are not developed together, it makes sense to use HTTPS instead of SSH anyways.
This small patch fixes it and I've confimred that using this pluging in a dotfiles repo on Codespaces does work with the patch applied.