Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add i18n support for default error messages #16

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

elephantoss
Copy link
Contributor

@srcrip I test locally with a project of mine and it works as expected.

Please let me know if you don't like the direction of the solution and I can try to explore other ideas.

closes #13

@srcrip
Copy link
Owner

srcrip commented Jul 9, 2024

That is some really great looking work so far. I'm glad you opened this cause I don't use gettext much. Just assign me for review whenever you're ready for me to formally review. Only request I have is that it would be nice if we could have some tests around this.

@elephantoss
Copy link
Contributor Author

@srcrip I'll add tests in the demo folder and I ping you when it is done

@elephantoss
Copy link
Contributor Author

@srcrip I added the test but I don't have permission to assign you as a reviewer.

@srcrip
Copy link
Owner

srcrip commented Jul 10, 2024

Wonderful! I'll take a look.

@elephantoss
Copy link
Contributor Author

@srcrip do you have any idea when you'll be able to review this PR?

@elephantoss
Copy link
Contributor Author

@srcrip I think I've found a way to simplify this PR a little bit. I'll play around a bit and try to push a new version in the next couple of days

@elephantoss
Copy link
Contributor Author

@srcrip just pushed a new version that is less intrusive and more straightforward to use.

@elephantoss
Copy link
Contributor Author

@srcrip, I'd appreciate some feedback on this PR. Specially if there is anything preventing you from merging it.

Thanks in advance

@srcrip
Copy link
Owner

srcrip commented Oct 7, 2024

Thank you! Sorry for the delay, I've been working on a different feature that's taken up a lot of my time for the project.

@srcrip srcrip merged commit eaaf459 into srcrip:master Oct 7, 2024
srcrip added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for i18n
2 participants