Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user if parallelization is disabled at runtime and why #3945

Closed
wants to merge 1 commit into from

Conversation

Luc45
Copy link

@Luc45 Luc45 commented Mar 28, 2024

Description

This PR introduces messages to inform users when parallelization is disabled at runtime and the reasons for it. These enhancements aim to improve user awareness in scenarios where parallel processing gets disabled due to unmet conditions like the absence of the pcntl PHP extension or high verbosity settings. By providing this information, users can better understand the behavior of the system and take appropriate actions if needed.

Suggested changelog entry

  • Added informative messages to notify users when parallel processing is disabled due to the absence of the 'pcntl' extension or high verbosity settings.

Related issues/external references

Fixes #

Disclaimer

I'm opening this PR from GitHub web. I don't have a local development copy of PHPCS to test this locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
  • [Required for new files] I have added any new files to the package.xml file.

@jrfnl
Copy link
Contributor

jrfnl commented Mar 28, 2024

@Luc45 I'm fairly sure you are aware of #3932 ... i.e. don't open PRs in this repo anymore....

@Luc45
Copy link
Author

Luc45 commented Mar 28, 2024

Ah yes, I forgot about that. Will port it over there, thanks.

@Luc45
Copy link
Author

Luc45 commented Mar 28, 2024

Ported to PHPCSStandards/PHP_CodeSniffer#419

Closing this

@Luc45 Luc45 closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants