PSR12/AnonClassDeclaration: prevent fixer creating parse error #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix prevents the fixer from removing the opening brace when there is no whitespace between the last character of the name of an interface and the open brace. With this fix in place, all other symptoms reported are also gone as they were a side-effect of the parse error being created. Includes unit test. Fixes 3790
jwittorf
approved these changes
Apr 2, 2023
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#56 |
jrfnl
deleted the
feature/3790-psr12-anonclassdeclaration-prevent-parse-error
branch
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix prevents the fixer from removing the opening brace when there is no whitespace between the last character of the name of an interface and the open brace.
With this fix in place, all other symptoms reported are also gone as they were a side-effect of the parse error being created.
Includes unit test.
Fixes #3790