Commits on Mar 2, 2023

1. PSR1/SideEffects: improve recognition of disable/enable annotations …

   As it was, the sniff would respect PHPCS disable annotations, but only when either unqualified or qualified up to a sniff name.
   It would not respect a disable annotation using a sniffname with errorcode, i.e. `PSR1.Files.SideEffects.FoundWithSymbols`.
   
   While the `FoundWithSymbols` errorcode is the only error code for this sniff and using `// phpcs:disable PSR1.Files.SideEffects.FoundWithSymbols` is effectively the same as using `// phpcs:disable PSR1.Files.SideEffects`, I do believe end-users should not need to be aware of whether or not a sniff has multiple error codes when using disable annotations.
   
   This updates the sniff to also respect disable annotations which include the error code.
   
   Includes unit test.
   
   Fixes 3386

   

   jrfnl committed Mar 2, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for fbbf8e0
   • Browse repository at this point

   Copy the full SHA

   fbbf8e0 View commit details

   Browse the repository at this point in the history