-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(shortcodes): Add demo repository badge #7915
docs(shortcodes): Add demo repository badge #7915
Conversation
Thanks for the PR. Just to knit pick, I'm not really happy with "examplerepo". Also, where would we use it? Could you add suggestions in this PR, so we can learn whether we really want/need this? |
I think it's a good addition to the Likewise to squidfunk I think that the name |
Good point. That's definitely a better formulation than the one I made. |
+1 for Kamil's proposal! |
@niclasheinz are you still wanting to progress on this PR? If so, it would be great if you could find the time to include the proposed changes by Kamil
Thanks in advance! |
Hi @squidfunk Thanks for reminding me, I forgot about it because I'm busy at the moment. I'll catch up in a few days. |
No hurry! Just wanted to know whether there are any impediments. Take your time |
@squidfunk It's ready for review 😄 |
I feel like the idea branched off into another direction. The The Either I'm making sense, or the separate |
Thanks for your feedback! I thought demonstration is better for a ‘live-demonstration’ where I can see what the result might look like. And the associated repository is the ‘demo’. That's why I originally chose ‘examplerepo’ as the name. But yes, your view also makes sense. What do you think @squidfunk? |
Thanks for making the changes. However, I'm with Kamil here, so please keep the example as-is. An example is a show case of a specific feature. We can add the demo code for the blog, social card and versioning demo, which is more involved, as it includes several features, but we should really keep it simple. Just follow the style of the example code in the hook. |
Okay, I have adjusted it |
Thanks again! We're almost there. I just realized that you made all your changes in the |
Also please see Alex' excellent guide on how to create a PR on this repository. |
cc08cd7
to
647babb
Compare
Thanks for the tip - reading will get me much further in life 😅 I'll keep my fingers crossed that it's right now. |
No worries! I know it can be challenging at first. As you know from our last call, we're also working on making things much simpler in the near future |
I have solved the problem |
Perfect, LGTM! Merging through. |
Hi @squidfunk
There are some example repositories at https://github.com/mkdocs-material, but these are not listed in the documents. With the new badge, the example repositories can be linked in the documentation.