Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty workflowDidChange from Xcode project templates #314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove empty workflowDidChange from Xcode project templates #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Samples/AsyncWorker/Sources/AsyncWorkerWorkflow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ extension AsyncWorkerWorkflow {
func makeInitialState() -> AsyncWorkerWorkflow.State {
return State(model: Model(message: "Initial State"))
}

func workflowDidChange(from previousWorkflow: AsyncWorkerWorkflow, state: inout State) {}
}

// MARK: Actions
Expand Down
2 changes: 0 additions & 2 deletions Tooling/Templates/Workflow (Verbose).xctemplate/Default/___FILEBASENAME___Workflow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ extension ___VARIABLE_productName___Workflow {
func makeInitialState() -> ___VARIABLE_productName___Workflow.State {
return State()
}

func workflowDidChange(from previousWorkflow: ___VARIABLE_productName___Workflow, state: inout State) {}
}

// MARK: Actions
Expand Down
2 changes: 0 additions & 2 deletions ...orkflow (Verbose).xctemplate/generateWorkerReactiveSwift/___FILEBASENAME___Workflow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ extension ___VARIABLE_productName___Workflow {
func makeInitialState() -> ___VARIABLE_productName___Workflow.State {
return State()
}

func workflowDidChange(from previousWorkflow: ___VARIABLE_productName___Workflow, state: inout State) {}
}

// MARK: Actions
Expand Down
2 changes: 0 additions & 2 deletions ...ates/Workflow (Verbose).xctemplate/generateWorkerRxSwift/___FILEBASENAME___Workflow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ extension ___VARIABLE_productName___Workflow {
func makeInitialState() -> ___VARIABLE_productName___Workflow.State {
return State()
}

func workflowDidChange(from previousWorkflow: ___VARIABLE_productName___Workflow, state: inout State) {}
}

// MARK: Actions
Expand Down
2 changes: 0 additions & 2 deletions Workflow/Sources/Workflow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ extension Workflow where State == Void {
public func makeInitialState() -> State {
return ()
}

public func workflowDidChange(from previousWorkflow: Self, state: inout State) {}
}

extension Workflow {
Expand Down
2 changes: 0 additions & 2 deletions Workflow/Tests/AnyWorkflowTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ private struct OnOutputWorkflow: Workflow {
false
}

func workflowDidChange(from previousWorkflow: OnOutputWorkflow, state: inout Bool) {}

func render(state: State, context: RenderContext<OnOutputWorkflow>) -> Bool {
OnOutputChildWorkflow()
.onOutput { state, output in
Expand Down
2 changes: 0 additions & 2 deletions WorkflowCombine/TestingTests/TestingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,6 @@ private struct TestWorkflow: Workflow {
.init(mode: .idle, output: "")
}

func workflowDidChange(from previousWorkflow: TestWorkflow, state: inout State) {}

func render(state: State, context: RenderContext<TestWorkflow>) {
switch state.mode {
case .idle:
Expand Down
2 changes: 0 additions & 2 deletions WorkflowConcurrency/TestingTests/TestingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ private struct TestWorkflow: Workflow {
.init(mode: .idle, output: "")
}

func workflowDidChange(from previousWorkflow: TestWorkflow, state: inout State) {}

func render(state: State, context: RenderContext<TestWorkflow>) {
switch state.mode {
case .idle:
Expand Down
2 changes: 0 additions & 2 deletions WorkflowReactiveSwift/TestingTests/TestingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,6 @@ private struct TestWorkflow: Workflow {
.init(mode: .idle, output: "")
}

func workflowDidChange(from previousWorkflow: TestWorkflow, state: inout State) {}

func render(state: State, context: RenderContext<TestWorkflow>) {
switch state.mode {
case .idle:
Expand Down
2 changes: 0 additions & 2 deletions WorkflowRxSwift/TestingTests/TestingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,6 @@ private struct TestWorkflow: Workflow {
.init(mode: .idle, output: "")
}

func workflowDidChange(from previousWorkflow: TestWorkflow, state: inout State) {}

func render(state: State, context: RenderContext<TestWorkflow>) {
switch state.mode {
case .idle:
Expand Down
Loading