-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Worker.Output Sendable #313
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this break register? I would be surprised if all Workers Outputs were Sendable.
I ran a local test a couple of weeks ago with no issues.
|
Integration passed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before we proceed further with this effort, i think we should have a bit of discussion around the motivation and future direction of this type of change to better expose things to the concurrency system. two thoughts that come to mind:
- imposing a
Sendable
conformance on a type is a fairly substantial ask in general since it's asserting that type must be able to be passed across arbitrary isolation domains. is this the right approach? - is this potentially a source-break for existing clients, so would necessitate a major semver bump? (granted register is probably the primary one)
That makes sense. For background, this came up because of a warning currently in
This is probably the right approach, given what
Yes it does have the potential to break clients if their |
Adds
Sendable
conformance as a constraint onWorkflow.Output
.Checklist