Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
we've had a few cases come up recently where it'd be nice to have a way to add log statements to portions of the workflow runtime which can then be 'externally recorded'. the main motivation in my mind is to add some diagnostic logs into 'exceptional' cases that we'd prefer not to happen. if we can collect these from client applications, we'll then be able to ensure that, say, changing a warning log/assertion to a fatal error won't cause huge problems 'in the wild'.
here's a pros/cons list of some of the possible implementation approaches considered for this task:
Description
for this PR, i've gone with option
1
and named/structured things somewhat similarly to how they look & work in SwiftLog. looking for feedback on the general approach, and thoughts on the design problem.Checklist