Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compose 1.6.8, compose compiler 1.5.4, kotlin 1.9.20 #1216

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

compose 1.6.8, compose compiler 1.5.4, kotlin 1.9.20 #1216

wants to merge 2 commits into from

Commits on Jul 31, 2024

  1. DialogCollator destroys/rebuild instead of dismiss/show 

    When `DialogCollator` has to reorder, it did so by calling `Dialog.dismiss()` and `Dialog.show()`. #1213 fixed a problem that caused for `ComposeView`, but that fix is undone by Compose 1.6.8. Ngoc Vu dug in to see why and discovered:

> The `onClick` in `Modifier.clickable` is passed all the way down to `pointerInputHandler` in `SuspendingPointerInputModifierNodeImpl` (when the screen is responsive, you should see `pointerInputHandler()` being called in `SuspendingPointerInputModifierNodeImpl#onPointerEvent`).
>
> After shuffling the overlays, even though the `ClickableNode` is found and `SuspendingPointerInputModifierNodeImpl#onPointerEvent` is called, `pointerInputHandler()` is never called  because the `pointerInputJob` in `SuspendingPointerInputModifierNodeImpl` was launched from a canceled coroutineScope. Tracking down that coroutineScope shows that it was canceled when `DialogCollator` calls `Dialog.dismiss` -> `onViewDetachedFromWindow`  -> `Recomposer.cancel()`. So it makes sense why destroying/rebuilding instead of dismissing and reusing the dialog fixes this issue.

Still need to put together a non-workflow repro sample and submit a bug to the Compose team, but this unblocks our move to Compose 1.6.8 in the meantime.
    @rjrjr
    rjrjr committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    66c65e9 View commit details
    Browse the repository at this point in the history

  2. compose 1.6.8, compose compiler 1.5.4, kotlin 1.9.20

    @rjrjr
    rjrjr committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b4b3b6e View commit details
    Browse the repository at this point in the history