all target can be non-exclusive via CLI #3107
Merged
+85
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
approved these changes
Sep 16, 2024
oldergod
force-pushed
the
bquenaudon.2024-09-16.exclusivityVIPyo
branch
from
d348481
to
a56dabb
Compare
swankjesse
approved these changes
Sep 16, 2024
Comment on lines
161
to
170
| val args = ArrayList<String>() | ||
| args.add(TargetLanguage.JAVA.protoPathArg()) | ||
| args.add(TargetLanguage.JAVA.outArg("/".toPath() / testDir)) | ||
| args.add(TargetLanguage.KOTLIN.protoPathArg()) | ||
| args.add(TargetLanguage.KOTLIN.outArg("/".toPath() / testDir)) | ||
| args.add(TargetLanguage.SWIFT.protoPathArg()) | ||
| args.add(TargetLanguage.SWIFT.outArg("/".toPath() / testDir)) | ||
| args.add("--no_kotlin_exclusive") | ||
| args.add("--no_swift_exclusive") | ||
| args.add("--dry_run") |
There was a problem hiding this comment.
Suggested change
| val args = ArrayList<String>() | |
| args.add(TargetLanguage.JAVA.protoPathArg()) | |
| args.add(TargetLanguage.JAVA.outArg("/".toPath() / testDir)) | |
| args.add(TargetLanguage.KOTLIN.protoPathArg()) | |
| args.add(TargetLanguage.KOTLIN.outArg("/".toPath() / testDir)) | |
| args.add(TargetLanguage.SWIFT.protoPathArg()) | |
| args.add(TargetLanguage.SWIFT.outArg("/".toPath() / testDir)) | |
| args.add("--no_kotlin_exclusive") | |
| args.add("--no_swift_exclusive") | |
| args.add("--dry_run") | |
| val args = mutableListOf( | |
| TargetLanguage.JAVA.protoPathArg(), | |
| TargetLanguage.JAVA.outArg("/".toPath() / testDir), | |
| TargetLanguage.KOTLIN.protoPathArg(), | |
| TargetLanguage.KOTLIN.outArg("/".toPath() / testDir), | |
| TargetLanguage.SWIFT.protoPathArg(), | |
| TargetLanguage.SWIFT.outArg("/".toPath() / testDir), | |
| "--no_kotlin_exclusive", | |
| "--no_swift_exclusive", | |
| "--dry_run", | |
| ) |
Comment on lines
184
to
185
| val fs = fileSystem | ||
| val compiler = WireCompiler.forArgs(fs, logger, *args.toTypedArray<String>()) |
There was a problem hiding this comment.
Suggested change
| val fs = fileSystem | |
| val compiler = WireCompiler.forArgs(fs, logger, *args.toTypedArray<String>()) | |
| val compiler = WireCompiler.forArgs(fileSystem, logger, *args.toTypedArray<String>()) |
Base automatically changed from
bquenaudon.2024-09-16.compilermultipletargets
to
master
September 16, 2024 15:01
oldergod
force-pushed
the
bquenaudon.2024-09-16.exclusivityVIPyo
branch
from
a56dabb
to
3844028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.