Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing comments support on windows #2908

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Trailing comments support on windows #2908

wants to merge 1 commit into from

Conversation

oldergod
Copy link
Member

Fixes #2905

@oldergod
Copy link
Member Author

Would you have a guess as to why it works @yschimke ?

@oldergod
Copy link
Member Author

I guess I should try to read a file on disk...? Or explicitly insert \r\n in the content

@yschimke
Copy link

Yeah, try manually inserting windows newlines?

@oldergod oldergod force-pushed the bquenaudon.2024-04-15.trailingcomments branch from 0813087 to 29d654f Compare April 15, 2024 13:37
@oldergod oldergod force-pushed the bquenaudon.2024-04-15.trailingcomments branch from 29d654f to 0d53db4 Compare April 15, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proto generation fails on Windows with trailing comments
2 participants
@oldergod @yschimke