Allow empty paths to merge nested data into the top level.#23
Open
seyfahni wants to merge 1 commit intosquare:mainfrom
Open
Allow empty paths to merge nested data into the top level.#23seyfahni wants to merge 1 commit intosquare:mainfrom
seyfahni wants to merge 1 commit intosquare:mainfrom
Conversation
f811a14 to
d9fe6b9
Compare
Contributor
|
I'll have to sit on this one for a while. I'm not fully convinced this is something we'd want here |
Contributor
Author
|
Yeah, I expected that. But it allows for some quite nice code sharing. I created this for serializing a request that looks like one big json object, but has a few fields that are decided based on another values content. And with this you can just inline those values instead or duplicating much of the code (all the other values). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deserialization of properties marked with
#[Json(path: [])did already work, but serialization did not.I wrote tests to verify this behavior and adjusted the Json class to make serialization work too.
My tests cover the following cases (both serialization and deserialization):
You can of course decide if you want this to be officially possible.