Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure openInputStream cannot kill calling process #2340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

herriojr
Copy link

@herriojr herriojr commented Nov 8, 2022

This addresses issue #2339

ContentResolver.openInputStream falls back to using a stable content provider which will kill the main process if it fails. Never trust an external process as there may be many things that might cause this such as reinstalls, application updates, etc. Fall back to a FileNotFoundException.

This addresses issue square#2339

ContentResolver.openInputStream falls back to using a stable content
provider which will kill the main process if it fails. Never trust an
external process as there may be many things that might cause this such
as reinstalls, application updates, etc. Fall back to a
FileNotFoundException.
@nathanmeade
Copy link

@herriojr I believe you need to add a reviewer such as @jrodbx to have this reviewed and merged

@herriojr
Copy link
Author

@nathanmeade Apparently I don't have enough privs to do so? I can't modify the reviewers here like I can with other projects I work on.

@nathanmeade
Copy link

@herriojr I looked around for the contributing guidelines and I found this:

Contributing
If you would like to contribute code you can do so through GitHub by forking the repository and sending a pull request.

When submitting code, please make every effort to follow existing conventions and style in order to keep the code as readable as possible. Please also make sure your code compiles by running mvn clean verify.

Before your code can be accepted into the project you must also sign the [Individual Contributor License Agreement (CLA)](http://squ.re/sign-the-cla).

(from: https://square.github.io/picasso/)

After all of the above is squared away my best guess would be to try to ping the most recent reviewers of the PRs (jrodbx, afollestad,...)

@herriojr
Copy link
Author

@nathanmeade all that was completed before I bother with the pull request.

@herriojr
Copy link
Author

herriojr commented Jan 5, 2023

@jrodbx any input on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants