Get WASI set up enough to do a directory list #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Jul 20, 2023
...💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛💜💙💚💛
Outdated
Show resolved
Hide resolved
swankjesse
force-pushed
the
jwilson.0720.wasi_file_system
branch
from
da1675b
to
de46239
Compare
swankjesse
commented
Jul 20, 2023
|
|
||
| // In theory, fd_readdir uses a 'cookie' field to page through results. In practice the NodeJS | ||
| // implementation doesn't honor the cookie and directories with large file names don't progress. | ||
| // Instead, just grow the buffer until the entire directory fits. |
There was a problem hiding this comment.
FYI @sdeleuze not sure if you ran into similar problems. I tested this on some long file names and it got very grumpy very fast.
There was a problem hiding this comment.
I did not test it with very long filenames, thanks for the feedback.
swankjesse
commented
Jul 20, 2023
I can't yet import AbstractFileSystemTest as that has a kotlinx-datetime dependency, and that artifact isn't available to WASM.
oldergod
approved these changes
Jul 21, 2023
okio-wasifilesystem/src/wasmMain/kotlin/okio/internal/preview1/Wasi.kt
Outdated
Show resolved
Hide resolved
whyoleg
reviewed
Jul 21, 2023
oldergod
approved these changes
Jul 21, 2023
It doesn't work on Windows yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.