[speculative/not to land] Add pcap logging for decorated sockets#9338
Draft
yschimke wants to merge 5 commits intosquare:masterfrom
Draft
[speculative/not to land] Add pcap logging for decorated sockets#9338yschimke wants to merge 5 commits intosquare:masterfrom
yschimke wants to merge 5 commits intosquare:masterfrom
Conversation
Adds a RecordingSocketFactory that decorates a TCP socket and captures events as Pcap or a sealed event trait. A potential debugging tool... - after the fact flaky tests - visibility into HTTP/2 frames - confirming behaviour of mock sockets The last point is why I'm exploring this. See whether we can run some category of tests without real I/O and flakiness. Run in near instant time.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likely this goes nowhere.
Adds a RecordingSocketFactory that decorates a TCP socket and captures events as Pcap or a sealed event trait. The pcap file is produced without running anything external like tshark.
A potential debugging tool...
The last point is why I'm exploring this. See whether we can run some category of tests without real I/O and flakiness. Run in near instant time.