Embed the public suffix database list directly inside a class

[yschimke]

Attempt a fix for #8580

Removes the need for proguard for the database. At the cost of more costly code generation at build time.

Point at which we parse the file

java.lang.Exception
	at okhttp3.internal.publicsuffix.EmbeddedPublicSuffixList.<clinit>(EmbeddedPublicSuffixList.kt:35)
	at okhttp3.internal.publicsuffix.PublicSuffixDatabase.<clinit>(PublicSuffixDatabase.kt:157)
	at okhttp3.Cookie$Companion.parse$okhttp(Cookie.kt:561)
	at okhttp3.Cookie$Companion.parse(Cookie.kt:450)
	at okhttp3.CookiesTest.acceptOriginalServerMatchesSubdomain(CookiesTest.kt:306)

Generated source looks like, and both the source and class file are 57KB.

  override val bytes: ByteString = "Y2l0eS5rYXdhc2FraS5qcApjaXR5LmtpdGFreXVzaHUuanAKY2l0eS5rb2JlLmpwCmNpdHkubmFnb3lhLmpwCmNpdHkuc2FwcG9yby5qcApjaXR5LnNlbmRhaS5qcApjaXR5Lnlva29oYW1hLmpwCnd3dy5jawo=".decodeBase64()!!

[yschimke]

Suggestions welcome!

[yschimke]

Since KotlinPoet generates source, this doesn't seem like a big win.

[yschimke]

Seems to kill the kotlin compiler

Maybe https://youtrack.jetbrains.com/issue/KT-72429/StackOverflowError-when-compiling-large-files

or

https://stackoverflow.com/a/60934758/1542667

[yschimke]

I shouldn't have uncompressed it. Will compare the compressed version

[JakeWharton]

I'll review the rest on desktop. Too dense for mobile.

[JakeWharton]

Seems like byteArrayOf would save even more space since it would be stored raw instead of as a string that is then encoded to bytes for the classfile.

[yschimke]

Yep, I'll try that. I was hitting limits of Kotlin? compiler before, with the source file like "...12, 15, -34, -56, 12..."

But let me try again

[yschimke]

Source back to 150KB, Kotlin compiler is noticeably struggling with the build. When the compile completes I'll report on the class file.

[yschimke]

I've given up on that for now.

[JakeWharton]

Probably worth filing a Kotlin issue if it's not fast. Although this project is stuck on old Kotlin with the old compiler, I believe.

Could also just generate package-private Java with a single static field.

[yschimke]

One alternative is to leave the existing implementation in src/main as the default, until we get a version that we are happy with and then switch.