-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better proguard rule #8399
base: master
Are you sure you want to change the base?
Better proguard rule #8399
Conversation
Version 5.0.0-alpha.14 with R8 currently crashes with |
Yep. We actually have what I hoped were strong tests for this https://github.com/square/okhttp/blob/parent-5.0.0-alpha.14/android-test-app/src/androidTest/kotlin/okhttp/android/testapp/PublicSuffixDatabaseTest.kt Unfortunately we are sort of pinned on AGP 8.2, so it wasn't testing this effectively. Until I untangle that, I'll try to reproduce the issue with a hacked build, and then apply the fix. |
@mtotschnig I can't reproduce that error, even bumping to AGP 8.5. Are you able to provide a repro? At the moment this seems like a nice to have, improving the names. But I'd like to understand why it's failing for you. |
@yschimke I tried with a minimal example, but was not able to reproduce yet.
So you need a situation with Cookies, but I tried to directly put the offending call |
I was trying to find differences between the project where the problem arises, and the minimal problem where it does not, and align them with respect to Kotlin and Java versions, but was not able to find out what makes the difference. |
Better fix #7827, no need to keep names #8156