Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OkHttpClient.Builder network pinning on Android #8376

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

OkHttpClient.Builder network pinning on Android #8376

wants to merge 5 commits into from

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Apr 20, 2024 •
edited
Loading

Cleanly pinning network on Android - #8286
Redo the Async DNS API, but internal for now - #8318

    val network1: android.net.Network

    val network1Client =
      defaultClient.newBuilder()
        .withNetwork(network = network1)
        .build()

@yschimke yschimke requested a review from swankjesse April 20, 2024 11:46
@yschimke yschimke added the android Relates to usage specifically on Android label Apr 20, 2024
@yschimke yschimke mentioned this pull request Apr 20, 2024
Open
@yschimke yschimke marked this pull request as ready for review April 20, 2024 17:18
@yschimke yschimke changed the title Draft of network pinning on Android OkHttpClient.Builder network pinning on Android Apr 20, 2024
yschimke
yschimke commented Apr 26, 2024
View reviewed changes
okhttp/api/okhttp.api Outdated Show resolved Hide resolved
@yschimke
OkHttpClient.Builder network pinning on Android
3511e1a 
Cleanly pinning network on Android - square#8286
Redo the Async DNS API, but internal for now - square#8318
@yschimke yschimke requested a review from JakeWharton January 4, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse left review comments

@JakeWharton JakeWharton Awaiting requested review from JakeWharton

Assignees
No one assigned
Labels
android Relates to usage specifically on Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @swankjesse