Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Android Client Builder following Coil, Koin patterns #7846

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented May 21, 2023

Follow pattern from Coil implementing an app singleton, with interface for using Application as a factory.

Breaking up a larger okhttp-android PR

TODO

  • tests
  • docs

@yschimke yschimke requested a review from swankjesse May 21, 2023 11:40
@yschimke yschimke added the android Relates to usage specifically on Android label May 27, 2023
# Conflicts:
#	okhttp/src/androidMain/kotlin/okhttp3/android/AndroidClientBuilder.kt
#	okhttp/src/androidMain/kotlin/okhttp3/android/OkHttpClientContext.kt
#	okhttp/src/androidMain/kotlin/okhttp3/android/OkHttpClientFactory.kt
@yschimke yschimke marked this pull request as ready for review January 4, 2025 11:31
@yschimke yschimke requested a review from JakeWharton January 4, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Relates to usage specifically on Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant