Swap order of new member in AddressPolicy

square · Apr 24, 2024 · c6a955f · c6a955f
1 parent a4befc3
commit c6a955f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/okhttp/api/okhttp.api b/okhttp/api/okhttp.api
@@ -393,8 +393,8 @@ public final class okhttp3/ConnectionPool$AddressPolicy {
 	public final field maximumConcurrentCallsPerConnection I
 	public final field minimumConcurrentCalls I
 	public fun <init> ()V
-	public fun <init> (IIJI)V
-	public synthetic fun <init> (IIJIILkotlin/jvm/internal/DefaultConstructorMarker;)V
+	public fun <init> (IJII)V
+	public synthetic fun <init> (IJIIILkotlin/jvm/internal/DefaultConstructorMarker;)V
 }
 
 public final class okhttp3/ConnectionSpec {

diff --git a/okhttp/src/main/kotlin/okhttp3/ConnectionPool.kt b/okhttp/src/main/kotlin/okhttp3/ConnectionPool.kt
@@ -148,15 +148,14 @@ class ConnectionPool internal constructor(
      * Connections will still be closed if they idle beyond the keep-alive but will be replaced.
      */
     @JvmField val minimumConcurrentCalls: Int = 0,
+    /** How long to wait to retry pre-emptive connection attempts that fail. */
+    @JvmField val backoffDelayMillis: Long = 60 * 1000,
+    /** How much jitter to introduce in connection retry backoff delays */
+    @JvmField val backoffJitterMillis: Int = 100,
     /**
      * The maximum number of concurrent calls per connection.
-     *
      * Set this value to 1 to disable HTTP/2 connection coalescing
      */
     @JvmField val maximumConcurrentCallsPerConnection: Int = Int.MAX_VALUE,
-    /** How long to wait to retry pre-emptive connection attempts that fail. */
-    @JvmField val backoffDelayMillis: Long = 60 * 1000,
-    /** How much jitter to introduce in connection retry backoff delays */
-    @JvmField val backoffJitterMillis: Int = 100,
   )
 }
diff --git a/okhttp/src/main/kotlin/okhttp3/internal/connection/RealConnection.kt b/okhttp/src/main/kotlin/okhttp3/internal/connection/RealConnection.kt
@@ -357,7 +357,7 @@ class RealConnection(
     connection: Http2Connection,
     settings: Settings,
   ) {
-   this.withLock {
+    this.withLock {
       this.lastMaxConcurrentStreamsFromSettings = settings.getMaxConcurrentStreams()
       recalculateAllocationLimit()
     }
@@ -369,7 +369,7 @@ class RealConnection(
    * made during settings changes
    */
   internal fun recalculateAllocationLimit() {
-   this.withLock {
+    this.withLock {
       val oldLimit = allocationLimit
       allocationLimit = getMaximumAllocationLimit()
 
@@ -425,7 +425,7 @@ class RealConnection(
     e: IOException?,
   ) {
     var noNewExchangesEvent = false
-   this.withLock {
+    this.withLock {
       if (e is StreamResetException) {
         when {
           e.errorCode == ErrorCode.REFUSED_STREAM -> {