Add FunSpec#jvmModifiers overload to fix chaining #653
Conversation
There was a problem hiding this comment.
This solution actually breaks compilation for Java users, since HIDDEN makes the old method inaccessible (I'm not entirely sure how this works, I just see the compilation error. Jake would know more). Besides, Java users would have to switch to jvmModifiersNew(), which is a pretty weird method name. Even though maintaining ergonomic Java API is not our top priority, I think this kind of change landing inside a minor version update is not good. I still think we should postpone this fix until 2.0. Luckily, in Kotlin it's very easy to wrap the method inside apply {}.
| fun jvmModifiers(modifiers: Iterable<Modifier>) { | ||
| @JvmName("jvmModifiers") | ||
| @Deprecated( | ||
| message = "This API was missing the Builder return type and breaks chaining. " + |
There was a problem hiding this comment.
The message here should target library users, not maintainers, something like "Deprecated. Use jvmModifiersNew()." would do.
| replaceWith = ReplaceWith("jvmModifiers(modifiers)"), | ||
| level = HIDDEN | ||
| ) | ||
| fun jvmModifersOld(modifiers: Iterable<Modifier>) { |
There was a problem hiding this comment.
typo: Modifers -> Modifiers
|
Talked offline, will leave to a future 2.x |
Resolves #638