Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an incorrect refactor that caused a crucial validity check to be omitted #526

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed an incorrect refactor that caused a crucial validity check to be omitted #526

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d3e8ba
Fixed a cfg error that was due to an incorrect refactor in commit bd2…
vdods Jul 29, 2023
0a1e563
Took out unnecessary feature gate.
vdods Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ssi-dids/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ impl FromStr for PrimaryDIDURL {
type Err = Error;
fn from_str(didurl: &str) -> Result<Self, Self::Err> {
// Allow non-DID URL for testing lds-ed25519-2020-issuer0
#[cfg(test)]
#[cfg(not(feature = "testing-lds-ed25519-2020-issuer0"))]
vdods marked this conversation as resolved.
Show resolved Hide resolved
if !didurl.starts_with("did:") {
return Err(Error::DIDURL);
}
Expand Down